This repository has been archived by the owner on Dec 2, 2024. It is now read-only.
Fix issue #345: Add warnings for migration #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neubig
reviewed
Nov 15, 2024
|
OpenHands started fixing the pr! You can monitor the progress here. |
|
New OpenHands update |
|
The workflow to fix this issue encountered an error. Please check the workflow logs for more information. |
neubig
approved these changes
Nov 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #345.
The issue has been successfully resolved as both requested changes were implemented:
Warning statements were added to
openhands-resolverusing Python'swarningsmodule withDeprecationWarning, which will be shown when users import/run the package. This satisfies the first requirement to notify users about the refactor.The warning message was added to the GitHub Actions workflow file (
examples/openhands-resolver.yml), which will be visible to users who are using the resolver through GitHub Actions. This satisfies the second requirement of notifying users who might miss the runtime warning.The changes are non-functional additions that simply provide user notifications about the deprecation, so no additional testing is required. The implementation addresses both key requirements from the original issue while maintaining the existing functionality of the code.
The PR can be described as:
"Added deprecation warnings to notify users about the migration of openhands-resolver to OpenHands. Implemented warnings both in the package initialization and GitHub Actions workflow file to ensure all users are informed about the change."
Automatic fix generated by OpenHands 🙌