Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AreaLights #7866

Open
sebavan opened this issue Mar 19, 2020 · 11 comments
Open

Add support for AreaLights #7866

sebavan opened this issue Mar 19, 2020 · 11 comments

Comments

@sebavan
Copy link
Member

sebavan commented Mar 19, 2020

Based on those researches, integrate supports for Area Lights:

@sebavan sebavan added this to the Future milestone Mar 19, 2020
@thomlucc thomlucc modified the milestones: Future, 4.2 Apr 14, 2020
@sebavan sebavan modified the milestones: 4.2, Future Jun 2, 2020
@thomlucc thomlucc added in progress Someone is currently working on this issue and removed help wanted labels May 18, 2021
@undefinedlee
Copy link

Which version of this feature is expected to be implemented

@deltakosh
Copy link
Contributor

We don't know yet. This is something we are looking for help if you are motivated

@thomlucc thomlucc removed the in progress Someone is currently working on this issue label Apr 12, 2022
@thomlucc thomlucc modified the milestones: Future, 6.0 Apr 12, 2022
@thomlucc thomlucc modified the milestones: 6.0, Future Oct 11, 2022
@Pryme8
Copy link
Contributor

Pryme8 commented Jan 10, 2023

Is this still something we want? I was looking at the code it would not really be that hard to convert, but it does look like it only supports planes at this moment.

@deltakosh
Copy link
Contributor

oh yes we want it. but we want it as a regular source (so for all meshes)

@Ivolutio
Copy link

Maybe PlayCanvas their implementation (light shapes) can also help. They have predefined shapes though.
Docs: https://developer.playcanvas.com/en/user-manual/graphics/lighting/lights/#light-shapes
Example: https://playcanvas.github.io/#/graphics/area-lights

@lokiiarora
Copy link
Contributor

Do we want shadow support as well?

@Popov72
Copy link
Contributor

Popov72 commented Sep 5, 2023

I don't think so, soft shadows can be simulated to some extent with PCSS or some other filter method. Generating accurate shadows for area lights would be quite time consuming I think.

@thomlucc thomlucc modified the milestones: 7.0, Future Jan 9, 2024
@thomlucc thomlucc removed this from the Future milestone Mar 12, 2024
@thomlucc thomlucc added this to the 8.0 milestone Mar 12, 2024
Copy link

This issue has been automatically staled because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions bot added the stale label Mar 28, 2024
@sebavan sebavan removed the stale label Mar 28, 2024
Copy link

This issue has been automatically staled because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions bot added the stale label Apr 25, 2024
@sebavan sebavan removed the stale label Apr 25, 2024
Copy link

This issue has been automatically staled because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions bot added the stale label May 24, 2024
@sebavan sebavan removed the stale label May 24, 2024
Copy link

This issue has been automatically staled because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions bot added the stale label Jun 22, 2024
@Popov72 Popov72 assigned SergioRZMasson and unassigned Popov72 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants