Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't easily see if I clicked an emoji without hovering to see names of who clicked it #43

Open
gregk-git opened this issue Apr 12, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@gregk-git
Copy link
Contributor

Describe the bug:
I can't easily see if a reaction is reacted to by me.

Expected behavior:
In the original GitHub style, because it's white, a reaction normally has a white background, and when you click on it, that becomes like a highlighted blue background. I don't know what colors would work best for your theme, perhaps the number should be white, and I don't know if that should be before or after your react.
Here's screenshots of what I mean with the original style:
Before you react:
image
After you react:
image

Where did this happen:
Any repo, but I used #29 to take screenshots to display this.

Steps to reproduce:
React by clicking an emoji on a comment on an issue post.

Screenshots:
Before reacting:
image

After reacting:
image

Desktop (please complete the following information):

  • OS: Both Windows 10 and ChromeOS
  • Browser: Both Firefox and Chrome
  • Version: Stable, Beta, and Canary Chrome, and on Version 68.7.0esr (64-bit) of Firefox-ESR

Additional add-ons installed:
Just stylus add-on and your style

@gregk-git gregk-git added the bug Something isn't working label Apr 12, 2020
@Brettm12345
Copy link
Owner

This is actually the general background for tooltips. I'm gonna see if I can figure out the css

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants