Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Aura Spells + Enchant Keyword #169

Open
Hanmac opened this issue Apr 29, 2022 · 3 comments · May be fixed by #6996
Open

Refactor Aura Spells + Enchant Keyword #169

Hanmac opened this issue Apr 29, 2022 · 3 comments · May be fixed by #6996
Assignees
Labels
Game Mechanics keep no stale Rules compliance Bringing the engine or cards closer to CR

Comments

@Hanmac
Copy link
Contributor

Hanmac commented Apr 29, 2022

Rules wise Aura Spells should just check for their Enchant Keywords and these should handle the "can be attached" part.

  • The Corner cases: having an Aura become the copy of Old-Growth Troll, when it dies it returns as real Aura and it is gaining enchant Forest . now with two Enchant keywords, both needs to be respected.

  • if that's cleaned up, the Aura Spell can be created by CardFactory like other Spell Permanent are.

  • Enchant Targets are: Cards on the Battlefield, Cards in Graveyard, Players

  • The AI Logic can't be part of the Aura Spell anymore and should probably be either part of the keyword, or be part of an extra SVar.

  • cleanup other uses for FirstAttachSpell

  • The cleaned up enchant keyword needs to respect Tallowisp that explicit looks for enchant creature, not enchant creature you control

Rules:

15.1b Aura spells are always targeted. An Aura’s target is specified by its enchant keyword ability (see rule 702.5, “Enchant”)
702.5c If an Aura has multiple instances of enchant, all of them apply. The Aura’s target must follow the restrictions from all the instances of enchant. The Aura can enchant only objects or players that match all of its enchant abilities.

An Aura without enchant keyword would be unattached too. (and sent to the graveyard)

Ruling for Immovable Rod

If you target an Aura with Immovable Rod's last ability, it will lose its enchant ability and be put into its owner's graveyard because it can't legally enchant anything. An Equipment that loses its abilities loses its equip ability, so you won't be able to move it that way, but it will stay attached to the creature it's equipping, if any. (2021-07-23)

@Hanmac Hanmac added Game Mechanics Rules compliance Bringing the engine or cards closer to CR labels Apr 29, 2022
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

This issue has not been updated in a while and has now been marked as stale. Stale messages will be auto closed.

@Hanmac Hanmac added keep no stale and removed no-issue-activity labels Jul 4, 2023
@Hanmac Hanmac self-assigned this Jul 4, 2023
@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 17, 2025

@tool4ever when we got time, we might look into this issue to refactor "Enchant" Keyword

@Hanmac
Copy link
Contributor Author

Hanmac commented Jan 17, 2025

Many A:SP$ Attach still have their mana cost as Parameters, that might be removed first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game Mechanics keep no stale Rules compliance Bringing the engine or cards closer to CR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant