add integration testing hooks

ChlodAlejandro · Oct 18, 2022 · e394ea6 · e394ea6
1 parent 2dc0405
commit e394ea6
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/src/session/DeputyRootSession.ts b/src/session/DeputyRootSession.ts
@@ -529,6 +529,8 @@ export default class DeputyRootSession {
 		await casePage.addActiveSection( sectionName );
 
 		heading.insertAdjacentElement( 'afterend', el.render() );
+		await el.loadData();
+		mw.hook( 'deputy.load.cci.root' ).fire();
 
 		return true;
 	}

diff --git a/src/ui/root/DeputyContributionSurveyRevision.tsx b/src/ui/root/DeputyContributionSurveyRevision.tsx
@@ -172,7 +172,6 @@ export default class DeputyContributionSurveyRevision
 	 * @inheritDoc
 	 */
 	render(): HTMLElement {
-
 		const commentElement = <span
 			class="comment comment--without-parentheses"
 			/** Stranger danger! Yes. */

diff --git a/src/ui/root/DeputyContributionSurveyRow.tsx b/src/ui/root/DeputyContributionSurveyRow.tsx
@@ -803,8 +803,6 @@ export default class DeputyContributionSurveyRow implements DeputyUIElement {
 			{ this.element }
 		</div> as HTMLElement;
 
-		this.loadData();
-
 		return this.rootElement;
 	}
 

diff --git a/src/ui/root/DeputyContributionSurveySection.tsx b/src/ui/root/DeputyContributionSurveySection.tsx
@@ -301,6 +301,9 @@ export default class DeputyContributionSurveySection implements DeputyUIElement
 					csr, rowElements[ csr.title.getPrefixedText() ], line, this
 				);
 			} catch ( e ) {
+				console.warn( 'Could not parse row.', line, e );
+				// For debugging and tests.
+				mw.hook( 'deputy.errors.cciRowParse' ).fire( { line, e } );
 				rowElement = line;
 			}
 			if ( typeof rowElement !== 'string' ) {
@@ -394,6 +397,15 @@ export default class DeputyContributionSurveySection implements DeputyUIElement
 		} );
 	}
 
+	/**
+	 * Makes all rows of this section being loading data.
+	 *
+	 * @return A Promise that resolves when all rows have finished loading data.
+	 */
+	async loadData(): Promise<void> {
+		await Promise.all( this.rows.map( row => row.loadData() ) );
+	}
+
 	/**
 	 * @inheritDoc
 	 */