Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More minor guide issues #378

Open
ealmloff opened this issue Jan 7, 2025 · 0 comments · May be fixed by #385
Open

More minor guide issues #378

ealmloff opened this issue Jan 7, 2025 · 0 comments · May be fixed by #385
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@ealmloff
Copy link
Member

ealmloff commented Jan 7, 2025

Reading through the most recent version of the guide, there are still a couple of minor issues:

  • The link in the EventHandler section says EventListener instead of event handler
  • dispose method on signal doesn't exist
  • Global State with Context talks about two different methods of managing state: Context and GlobalSignal. It might make sense to switch to Context and Global which both accept arbitrary types
  • dioxus::spawn is not exported at that path. It is only in the prelude
  • The Enabling Fullstack section adds the server, but doesn't remove web as the default platform which will cause web to be enabled when building the server. This was fixed in the template, but is hasn't been fixed in the guide. After removing the web default feature, the guide should also mention you need to serve with --platform web
  • The backend guide mentions we don't expect a client feature, but the CLI does recognize web, desktop, and mobile as client features. We also expose a client macro to config out client only code
@ealmloff ealmloff added bug Something isn't working documentation Improvements or additions to documentation labels Jan 7, 2025
@ealmloff ealmloff self-assigned this Jan 7, 2025
@ealmloff ealmloff linked a pull request Jan 10, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant