-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of reflected XSSes #31
Comments
If we switch to handlebars everywhere, handlebars should (?) escape arbitrary strings correctly. However, we need to dedice on what should actually happen if a button (insert and deploy) is pressed. cc @fsck |
There are still xsses sprinkled about, for example here: Line 212 in 1962084
There is probably no good reason to ever reflect invalid user input. |
Imho we should throw out all content::Htmls, and use handlebars everywhere. Thoughts? |
As I said there is no reason to output the user input in error messages, static strings can never go wrong. |
Nevertheless content::Html is an unneccessary footgun - I'd rather throw it out completely than have xss issues coming up repeatedly. |
It seems like moet routes contain reflected cross site scripting.
This is bad, especially if hosted on the same subdomain as rocketchat or others.
Also, if we can't get this right, who can?
The text was updated successfully, but these errors were encountered: