Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node.js 16 #353

Open
1 of 6 tasks
LexLuengas opened this issue Jul 1, 2022 · 0 comments
Open
1 of 6 tasks

Upgrade to Node.js 16 #353

LexLuengas opened this issue Jul 1, 2022 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file
Milestone

Comments

@LexLuengas
Copy link
Collaborator

LexLuengas commented Jul 1, 2022

Migration to Node.js v16

Context

Version 16 is the current LTS version as of now (https://nodejs.org/en/about/releases/).

Currently

  • CI tests run on Node.js v10 and v12.
  • Dockerfile uses "node:17" image 😢.
  • The test/docker/run-docker-test.bash script runs using the "node:10.15.3" Docker image.
  • package.json file does not declare any node versions in "engines" section.
  • The .nvmrc file has v10.24.1.
  • GitHub action "npm-publish" uses v10 during step "actions/setup-node" but the step is probably unnecessary since it does not run anything.

Tasks

  • Consolidate node versions used across code base. Consider to have a single source for the version. A dev setup script might be needed.
  • Update local configuration.
  • Update build environment of GitHub actions.
  • Upgrade dependencies one-by-one.
  • Consider to remove dependencies that can be replaced by a Node.js API.\
  • Remove "actions/setup-node" step from "npm-publish" action. Consider to upgrade to the latest "pascalgn/npm-publish-action" for the publish step.

Out of scope

Linked issues

@LexLuengas LexLuengas added this to the 2.0.0 milestone Jul 1, 2022
@LexLuengas LexLuengas self-assigned this Jul 1, 2022
@LexLuengas LexLuengas added the dependencies Pull requests that update a dependency file label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant