Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to interact with BoundingBoxTree coordinates #3599

Open
ordinary-slim opened this issue Jan 15, 2025 · 1 comment
Open

Allow user to interact with BoundingBoxTree coordinates #3599

ordinary-slim opened this issue Jan 15, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@ordinary-slim
Copy link

Describe new/missing feature

I am working with mesh motion and would like to avoid recomputation of BoundingBoxTrees. In my case, the mesh motion is a simple translation so I would like to be able to shift the _bbox_coordinates of BoundingBoxTree by a 3D vector. The issue is that it is a private member of the class with no Python exposure.
Making the attribute protected instead of private would allow a user to inherit from the class and interact with it from there. Another option would be to expose it to Python the same way the mesh coordinates are exposed.

Suggested user interface

No response

@ordinary-slim ordinary-slim added the enhancement New feature or request label Jan 15, 2025
@jhale
Copy link
Member

jhale commented Jan 15, 2025

The latter option (exposing the coordinates) seems like the consistent approach. The docstring needs to reflect that this does not update the underlying tree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants