Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Default Group No Resources from Machines section (and column headings on remote machines) #192

Open
muziqaz opened this issue Sep 8, 2024 · 15 comments
Labels
enhancement New feature or request

Comments

@muziqaz
Copy link

muziqaz commented Sep 8, 2024

resource groups

I know we spoke about this before, that disabling Default group is a bit of the undertaking. Would it be possible to just hide it from Machines section Default Group if it does not have any assigned resources to it? At the moment UI gets quite busy, and that extra line per machine with that triangle at the end gets very distracting if one is monitoring their machines. Plus it would save some real estate vertically, so more remote machines would be visible without the need of scrolling down.

And maybe even hide column headings (Status, Project, RCG, Core, etc) for all but local machine. Here is an example of what I mean:
resource groups compact

So now if I glance at the bottom screenshot, I can easily see all the groups and machines are folding, and none are paused, while the first screenshot would make me double check, since I would spot these "Start" triangles at the end.

Thanks

@kbernhagen
Copy link
Contributor

kbernhagen commented Sep 8, 2024

If those are separate tables for each machine, the columns might not line up because of variable width content.

image

@muziqaz
Copy link
Author

muziqaz commented Sep 8, 2024

Yeah, I noticed that, though this might be mitigated by limiting character number in Machine name.
Finishing and Running length differences are not too bad, though. But overall, a lot of columns might have different lengths, you have a point.
This issue writeup came about mainly as to hide Default Resource Group, and column headings were just a "oh, by the way, this can go away" afterthought.

@kbernhagen
Copy link
Contributor

Might be nice to have an option to hide all groups with no resources, unless that would leave none visible.

@muziqaz
Copy link
Author

muziqaz commented Sep 8, 2024

I think just a Default Group with no resources should be hidden, as other groups might have no resources temporary while user is setting things up, and that might cause a lot of questions for new users.

@muziqaz
Copy link
Author

muziqaz commented Sep 14, 2024

I will just throw this in here :D
ideas ideas

@kbernhagen
Copy link
Contributor

Seems reasonable. If you have a wide screen.
The action buttons would only apply to the entire group.
Might confuse people who think they can pause individual WUs.

@jcoffland
Copy link
Member

I think it makes sense to not require the default group. Internally, the default group has the empty string as its name and it cannot be deleted. If you could rename the default group and delete it just like any other group then this wouldn't be an issue.

The other issue of combining the machine and groups sections in to one table makes some sense. As @kbernhagen mentioned, it leaves no place for the group or machine action buttons.

Finally, we have to strike a balance between the dense table view expert folders might like and a more user friendly view that makes F@H less daunting for new users. And it still needs to be usable on mobile screens.

@muziqaz
Copy link
Author

muziqaz commented Sep 16, 2024

Would it be possible to add colour coding for different machines? To give more contrast where one machine starts and another ends?
Above suggestions where just ideas, I understand that from my point of view with wide or ultra wide monitors, it might seem like we have loads of available space, but that wouldn't be the case for 4:3 crowd.
Though I would appreciate if Default Group|No Resources thing got hidden

@kbernhagen
Copy link
Contributor

Currently units have a group name, but that group is not guaranteed to exist. If a unit’s group has been deleted, the unit seems to belong to the default group.

If you remove group “” and a user has multiple groups created, which of those groups should be treated as the default group when a unit must be moved?

@kbernhagen
Copy link
Contributor

Might also want to disable deleting a group that has units or is not paused.

@kbernhagen
Copy link
Contributor

Note that a GPU unit that gets moved to a group with no appropriate GPU will be stuck paused for insufficient resources.

@muziqaz
Copy link
Author

muziqaz commented Sep 16, 2024

I think just hiding it from main page would be sufficient. As far as I understand, removing Default Group is out of the question due to technical reasons.
So if Default Group has no resources assigned to it, just don't show it on main page. In settings it will still be visible and if one wants to add some resources back to it, it can be unhidden in the main page.

Obviously deleting user created groups while that group is folding a WU should not be allowed

@jcoffland jcoffland added the enhancement New feature or request label Sep 17, 2024
@jcoffland
Copy link
Member

v8.4.5 add some extra columns: Version, Resources & Group. This is a step towards supporting a table with only WUs and no machine or group rows.

I still don't see a good way to display machine and group actions. One idea would be to have a separate table of machines and groups with no WUs and only show WUs on the WUs tab but then you have to move back and forth. Another idea is to have a popup with all the machine and group actions. I'm still not sold on either of these ideas.

@muziqaz
Copy link
Author

muziqaz commented Sep 17, 2024

I played around with different resolutions and monitor ratios. While my sketch proposal would work on normal 16:9, 16:10 or wider screens, it fails miserably with 4:3 ratio screens, unless users with such monitors majorly sacrifice amount of info columns they can add to main page without scrolling horizontally.
If we could settle for hidden Default Group | No Resource line, and maybe some colour coding for resource groups, that would probably be sufficient.
In regards to color coding, user could shade their CPU groups one color, while GPU groups something else. Or colour shades could be predetermined differenciating between CPU group and GPU group. If colours are too complicated, this is just an idea, and not really a requirement. Just thinking out loud to add a bit of contrast for eyes to pick up different machines and different groups quicker (but that might come with time, once we get completely used to UI). Plus I would think that web control UI might be open for some clever people writing plugins/skins for v8 down the line.

@kbernhagen
Copy link
Contributor

kbernhagen commented Sep 17, 2024

After restructuring lufah internals, I plan to give it an optional TUI using textual. My mockup interface might be interesting as a point of discussion. Here is a screenshot at terminal 80x24:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants