Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrink Minimum Size & Fix Calculations #197

Merged
merged 13 commits into from
Jan 19, 2025
Merged

Shrink Minimum Size & Fix Calculations #197

merged 13 commits into from
Jan 19, 2025

Conversation

Gold872
Copy link
Owner

@Gold872 Gold872 commented Jan 15, 2025

  • Dynamically hide title if window is too small
  • Shrink menu bar buttons
  • Move update icon into tab bar

Resolves #195 and #196

* Auto hide title text
* Fix notification overflows
* Move update icon
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 81.08108% with 21 lines in your changes missing coverage. Please review.

Project coverage is 75.96%. Comparing base (06291e0) to head (02b32f8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/pages/dashboard_page.dart 81.01% 15 Missing ⚠️
lib/main.dart 0.00% 3 Missing ⚠️
lib/widgets/custom_appbar.dart 80.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #197      +/-   ##
==========================================
+ Coverage   75.92%   75.96%   +0.03%     
==========================================
  Files          80       79       -1     
  Lines        8562     8558       -4     
==========================================
  Hits         6501     6501              
+ Misses       2061     2057       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Gold872
Copy link
Owner Author

Gold872 commented Jan 15, 2025

@jwbonner could you give this build a try and see if it resolves the issue? I don't have a way of testing on Mac

@jwbonner
Copy link

It seems to solve the problem with the starting size on macOS, but the minimum window size is now inconsistent between devices (testing on a Windows laptop and MacBook). On the Mac, I'm able to get down to a size of 1x3 grid squares at the default settings (🎉). On Windows the minimum size is smaller than before, but I'm limited to 3.5x6.5 grid squares which is more than half the horizontal length of the screen.

@Gold872
Copy link
Owner Author

Gold872 commented Jan 15, 2025

It seems to solve the problem with the starting size on macOS, but the minimum window size is now inconsistent between devices (testing on a Windows laptop and MacBook). On the Mac, I'm able to get down to a size of 1x3 grid squares at the default settings (🎉).

I'm sorry to ruin the fun but I did just have to increase the minimum width slightly because I forgot about the layout lock icon

On Windows the minimum size is smaller than before, but I'm limited to 3.5x6.5 grid squares which is more than half the horizontal length of the screen.

What are the resolutions and dpi of both of the devices? If it needs to be smaller I think I can shave off a few more pixels in the menu bar

- Collapse menu when width gets too small
- Auto hide team number and latency
- Use stack for footer instead of row
@Gold872
Copy link
Owner Author

Gold872 commented Jan 18, 2025

@jwbonner have you had the chance to try out the latest build of this PR? I think it should have all the features you were looking for

@jwbonner
Copy link

It seems like this still has the issue of the minimum size being very different on each device. Exactly what information do you need about the displays? The Windows display is 3240x2160 at 200% scaling, and the Mac is 3024x1964 with a display resolution of 1512x982.

@Gold872
Copy link
Owner Author

Gold872 commented Jan 18, 2025

Interesting, could you send screenshots of how it's appearing?

@jwbonner
Copy link

Minimum size on macOS (very good):
Screenshot 2025-01-18 at 6 58 59 PM

Minimum size on Windows (still larger than we would like):
Screenshot 2025-01-18 185944

@Gold872
Copy link
Owner Author

Gold872 commented Jan 19, 2025

Well I just pushed a fix that I believe did the exact opposite of that (makes macos behave like windows)

I'll see if I can mathematically reproduce the windows issue

@Gold872
Copy link
Owner Author

Gold872 commented Jan 19, 2025

Did some more testing, looks like my size calculation works perfectly, on my machine...

Looks like it's not responding well to different screen sizes, I'll have to do more testing on how the app actually responds on the different sizes, I'll keep you posted on my findings and whether I need you to test new builds

@Gold872
Copy link
Owner Author

Gold872 commented Jan 19, 2025

@jwbonner this should be it! Let me know if there's any issues

@jwbonner
Copy link

It seems to work as expected on macOS. I don't have access to the same Windows computer to test with, but if it seems consistent on multiple devices then it's probably fine.

@Gold872 Gold872 merged commit b94b099 into main Jan 19, 2025
9 checks passed
@Gold872 Gold872 deleted the fix-minimum-size branch January 19, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for smaller window sizes
2 participants