-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shrink Minimum Size & Fix Calculations #197
Conversation
* Auto hide title text * Fix notification overflows * Move update icon
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
+ Coverage 75.92% 75.96% +0.03%
==========================================
Files 80 79 -1
Lines 8562 8558 -4
==========================================
Hits 6501 6501
+ Misses 2061 2057 -4 ☔ View full report in Codecov by Sentry. |
@jwbonner could you give this build a try and see if it resolves the issue? I don't have a way of testing on Mac |
It seems to solve the problem with the starting size on macOS, but the minimum window size is now inconsistent between devices (testing on a Windows laptop and MacBook). On the Mac, I'm able to get down to a size of 1x3 grid squares at the default settings (🎉). On Windows the minimum size is smaller than before, but I'm limited to 3.5x6.5 grid squares which is more than half the horizontal length of the screen. |
I'm sorry to ruin the fun but I did just have to increase the minimum width slightly because I forgot about the layout lock icon
What are the resolutions and dpi of both of the devices? If it needs to be smaller I think I can shave off a few more pixels in the menu bar |
- Collapse menu when width gets too small - Auto hide team number and latency - Use stack for footer instead of row
@jwbonner have you had the chance to try out the latest build of this PR? I think it should have all the features you were looking for |
It seems like this still has the issue of the minimum size being very different on each device. Exactly what information do you need about the displays? The Windows display is 3240x2160 at 200% scaling, and the Mac is 3024x1964 with a display resolution of 1512x982. |
Interesting, could you send screenshots of how it's appearing? |
Well I just pushed a fix that I believe did the exact opposite of that (makes macos behave like windows) I'll see if I can mathematically reproduce the windows issue |
Did some more testing, looks like my size calculation works perfectly, on my machine... Looks like it's not responding well to different screen sizes, I'll have to do more testing on how the app actually responds on the different sizes, I'll keep you posted on my findings and whether I need you to test new builds |
@jwbonner this should be it! Let me know if there's any issues |
It seems to work as expected on macOS. I don't have access to the same Windows computer to test with, but if it seems consistent on multiple devices then it's probably fine. |
Resolves #195 and #196