-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all settings to Foundation if Foundation exists #154
Comments
@zackkatz You say
But that's on us, right? Wouldn't Foundation be included in the next major? Or is that not shipped with the plugin? If it is, I think we should port the settings to Foundation for consistency. If it isn't; then we should keep it on the plugin, to avoid having multiple places. |
We haven't prepared Foundation for .org. It will take some amount of work to make it compliant. @doekenorg |
Right, so In that case; I guess we could check for Foundation; and duplicate the settings over there; whilst saving them to the plugin for BC. |
Another option is to integrate Foundation but disable products/licensing if it's just GravityExport Lite that's using it. |
I like this option best TBH. Since we are moving to 2.0, this is the best time to introduce a new settings page + location where the settings are stored. |
@mrcasual we would need opt-in metrics reporting and Beacon |
If Foundation exists, the settings should be in a GravityExport tab (not a separate GravityExport Lite tab).
We need to think about where the setting would be saved (in the prior setting key or in Foundation settings…)
The text was updated successfully, but these errors were encountered: