-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document our bug reporting requirements and create an issue template which meets them. #586
Comments
@jmcook1186 see my note on #590, let's merge it makes more sense to work in these hand in hand, the guidance should be created first in my opinion as one informs the other, we might write the guidance and realize through that the template needs updating and vice versa. FYI: I'm assuming anything that involves a PR has had team approval implicitly. |
@jawache @jmcook1186 Proposing a new bug report template, which you can see and review on |
Thanks @MariamKhalatova, can you link the PR itself? |
@jmcook1186 I wanted to clarify a couple of things to see what needs to happen to move this one along:
|
There is a PR open for the bug reporting template itself (#654) but it needs approving and then replicating across the other IF repositories. Then I wanted to describe the bug triage process and reporting guidelines into the contribution guidelines in our docs and if readme. Actually makes most sense to assign this to me. |
@jmcook1186 for me the priority is the bug triage process (agreement for what's high, med, low) I can see you've done the majority of work there and from where I sit it looks like we just need to make a call. Happy for you to make it and others can weigh in if they don't agree (but it's been in that doc for a while so there has been plenty of opportunities for others to give their opinions). The template and reporting requirements would be defined by our triage requirements, e.g. if to triage high we need to understand X, X needs to be something people add to a bug report etc.. so I think the triage is the main one and everything else will follow naturally on from that. |
Re-opening as not all acceptance criteria are met. Only the bug template is merged so far - and it also needs replicating across the other IF repositories. @MariamKhalatova could you raise PRs to I am writing documentation for bug reporting requirements now. |
Update: Documentation added to IF readme and |
Bug reporting templates were updated in |
@MariamKhalatova please review and then we can merge and close this 💪 |
@jmcook1186 I reviewed these PRs , left some comments. Please check |
Sub of #651
What
Update the contribution guidelines in our main repository and docs website to help users report bugs effectively and Update the Github template for bug reports across IF repositories
Why
As a core developer I want to be able to diagnose, assess and fix bugs as quickly as possible.
As a user/community developer I want a clear way to report bugs to the core team so that they can be dealt with as quickly as possible.
As a core dev I want our users to submit bug reports in a standard format so we can triage it effectively and apply our decision making process consistently
As a user, I want a clear explanation of what's expected when I report a bug so I can be confident it will be handled effectively.
Context
We can make our bug response much more efficient and effective by clearly communicating to users what information we need to reproduce, diagnose and fix bugs. If users conform to our standard, we will be able to handle them in our triage calls without requiring lots of back and forth async discussion with the user. We are updating our bug report template in a separate ticket and this issue adds explicit guidance on how to fill out the template to our contribution documentation in the IF repository and our docs website to make sure users can provide us the information we need to address their issues efficiently and effectively.
Part of the QA epic. An updated bug report template will help users and developers provide all the information we need to triage, reproduce and fix bugs.
We should make it so a bug report contains all the information required to reproduce a bug and to make it as easy as possible to fix. This includes:
Statement of Work
if/contributing.md
(handled in Remove contributions page if-docs#69)if/contributions.md
(Handled in Add bug triage docs #663)This ticket covers any async discussions or calls required to confirm the information required on the bug reporting template, creating a PR to update the template on each of the IF repositories (
if
,if-plugins
,if-unofficial-plugins
,if-plugin-template
).Acceptance criteria
Guidance created that includes: (Handled in Add bug triage docs #663)
What criteria does a bug need for us to accept it (It must be reproducible and all the information and materials provided for us to reproduce the error)
Our rubric for triaging bugs into high, medium and low.
Our SLAs and actions for bugs that are high, medium or low.
Template created that includes
a description of the error
a description of the expected behaviour
a description of the actual behaviour
steps to reproduce (the exact CLI commands that were run)
EITHER
the manifest file that generated the error
links to any code (e.g. your own plugin code), it must be available online.
runtime information such as OS, node version, package.json, IF version
OR
A version of stackblitz which replicates the bug
All
if-*
repos have a bug report matching the above template(handled in Update issue templates in if-plugins if-plugins#84
Update issue templates in if-unofficial-plugins if-unofficial-plugins#80
Update issue template in if-plugin-template if-plugin-template#7)
Deadline
tbc
Reviewer
The text was updated successfully, but these errors were encountered: