From 203049b2f5decc0c5cf4df54d7459468d1002e1f Mon Sep 17 00:00:00 2001 From: Sean Molenaar Date: Fri, 28 Jun 2024 09:28:55 +0200 Subject: [PATCH] fix: improve audit for binary stanza --- Library/Homebrew/cask/audit.rb | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Library/Homebrew/cask/audit.rb b/Library/Homebrew/cask/audit.rb index 4b8bd523e18a3..0d73a538aedc1 100644 --- a/Library/Homebrew/cask/audit.rb +++ b/Library/Homebrew/cask/audit.rb @@ -580,15 +580,14 @@ def audit_rosetta add_error "No binaries in App: #{artifact.source}", location: cask.url.location if files.empty? system_command("lipo", args: ["-archs", files.first], print_stderr: false) when Artifact::Binary - system_command("lipo", args: ["-archs", path], print_stderr: false) + binary_path = path.to_s.gsub(cask.appdir, tmpdir) + system_command("lipo", args: ["-archs", binary_path], print_stderr: true) else add_error "Unknown artifact type: #{artifact.class}", location: cask.url.location end - unless result.success? - add_error "Failed to determine artifact architecture!", location: cask.url.location - next - end + # binary stanza can contain shell scripts, so we just continue if lipo fails. + next unless result.success? odebug result.merged_output