Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cask/audit: audit for appropriate sharding directory #15849

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

razvanazamfirei
Copy link
Member

@razvanazamfirei razvanazamfirei commented Aug 9, 2023

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This PR adds an audit to ensure casks are in the appropriate subdirectory.
Should help address the issue raised in Homebrew/homebrew-cask#152603

@razvanazamfirei razvanazamfirei requested a review from a team August 9, 2023 18:57
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine as-is but duplicating some logic that the suggestion should handle.

@MikeMcQuaid
Copy link
Member

Thanks @razvanazamfirei! Anyone: feel free to merge when comment addressed.

@MikeMcQuaid MikeMcQuaid merged commit 1a8f1be into Homebrew:master Aug 9, 2023
24 checks passed
@razvanazamfirei razvanazamfirei deleted the sharding-audit branch August 9, 2023 20:47
@github-actions github-actions bot added the outdated PR was locked due to age label Sep 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants