Zip extraction can fail on macOS

[ilia-db]

The Homebrew/actions/setup-homebrew@master checks out master branch of the brew repo.

We've noticed that on the macos-latest platform the brew started to fail during installation of our formula (databricks, see the repo) with the RuntimeError: Empty archive error.

This started happening after this commit in the main brew repo. Seems like currently brew/master is in the middle of ruby 3 transition - #16154

Here's the full output:

brew install databricks

==> Fetching databricks/tap/databricks
==> Downloading https://github.com/databricks/cli/releases/download/v0.210.1/databricks_cli_0.210.1_darwin_arm64.zip
Already downloaded: /Users/test/Library/Caches/Homebrew/downloads/9c26a0486093b428047042a5aee47dfabe84ef3b458f24abf0ca5e12f433b021--databricks_cli_0.210.1_darwin_arm64.zip
==> Verifying checksum for '9c26a0486093b428047042a5aee47dfabe84ef3b458f24abf0ca5e12f433b021--databricks_cli_0.210.1_darwin_arm64.zip'
==> Installing databricks from databricks/tap
Error: An exception occurred within a child process:
  RuntimeError: Empty archive

The problem disappears when we call brew install-bundler-gems before the installation.

Please correct me if it's not true, but I'm not sure running this command should be required - the expectation is that after adding Homebrew/actions/setup-homebrew@master step we can proceed to safely call brew install ... commands without additional setup.

[Bo98]

Please correct me if it's not true, but I'm not sure running this command should be required

Definitely not. Caching can be useful, but it's rare you ever need to do an explicit brew install-bundler-gems.

Setting HOMEBREW_DEVELOPER=1 as an env does seem to fix the issue. Looks like something that breaks without runtime typechecking enabled.

[Bo98]

Definitely a bug on the brew side. Will fix shortly.