Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of sorbet's deprecated hidden-definitions #16557

Closed
1 task done
dduugg opened this issue Jan 31, 2024 · 1 comment · Fixed by #16586
Closed
1 task done

Remove use of sorbet's deprecated hidden-definitions #16557

dduugg opened this issue Jan 31, 2024 · 1 comment · Fixed by #16586
Assignees
Labels
features New features outdated PR was locked due to age

Comments

@dduugg
Copy link
Member

dduugg commented Jan 31, 2024

Verification

Provide a detailed description of the proposed feature

hidden-definitions is slow, deprecated, and error-prone. Let's replace it with Tapioca DSL compilers and RBI files where needed. (It currently masks 160 type errors, though half of them should resolve when #16540 merges.)

What is the motivation for the feature?

☝️

How will the feature be relevant to at least 90% of Homebrew users?

Not so much

What alternatives to the feature have been considered?

We could maintain the status quo indefinitely

@MikeMcQuaid
Copy link
Member

Makes sense to me!

@dduugg dduugg self-assigned this Feb 5, 2024
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@MikeMcQuaid @dduugg and others