Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

livecheck/strategy: fix **unused type #16763

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Feb 28, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Based on https://sorbet.org/docs/sigs#rest-parameters, the method signature seems to be for the values of remaining keyword arguments.

In the sorbet doc example, the **kwargs has method signature type kwargs: Float and becomes T::Hash[Symbol, Float] in the method body.


Noticed when running brew livecheck -r --debug <formula> which would output

Parameter 'homebrew_curl': Expected type T.nilable(T::Hash[Symbol, T.untyped]), got type FalseClass

@reitermarkus reitermarkus merged commit fb09997 into Homebrew:master Feb 28, 2024
26 checks passed
@reitermarkus
Copy link
Member

Thanks!

@cho-m cho-m deleted the unused-type branch February 28, 2024 20:01
@MikeMcQuaid
Copy link
Member

Thanks @cho-m!

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 3, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants