Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FormulaTextAuditor. #17159

Closed
1 task done
reitermarkus opened this issue Apr 26, 2024 · 3 comments · Fixed by #17228
Closed
1 task done

Remove FormulaTextAuditor. #17159

reitermarkus opened this issue Apr 26, 2024 · 3 comments · Fixed by #17228
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age

Comments

@reitermarkus
Copy link
Member

Verification

Provide a detailed description of the proposed feature

Replace FormulaTextAuditor with RuboCops, if it isn't already.

What is the motivation for the feature?

FormulaTextAuditor is only used for two audits.

How will the feature be relevant to at least 90% of Homebrew users?

Easier maintenance.

What alternatives to the feature have been considered?

None.

@reitermarkus reitermarkus added help wanted We want help addressing this features New features labels Apr 26, 2024
@issyl0
Copy link
Member

issyl0 commented May 3, 2024

Yay! Were you planning on working on this, Markus, or can I take it? I have time this weekend to work on some of this (I'm on-call, so at home for once).

@issyl0
Copy link
Member

issyl0 commented May 4, 2024

The audit_text audit requires loading a formula and looking at its name, aliases and bin/sbin/etc. binary names. Since RuboCop is just a massive text processor, we might have to keep it around?

@reitermarkus
Copy link
Member Author

We load the formula anyways for audit, so we could add a TestAuditor which audits the test block by calling the block with overridden system, shell_output and pipe_output methods and method_missing with a list of allowed test methods.

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 6, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
features New features help wanted We want help addressing this outdated PR was locked due to age
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants