Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Vernier profiler #17316

Merged
merged 1 commit into from
May 20, 2024
Merged

Add support for Vernier profiler #17316

merged 1 commit into from
May 20, 2024

Conversation

MikeMcQuaid
Copy link
Member

Needs Ruby >=3.2 so blocked on that.

@Bo98 Bo98 force-pushed the portable-ruby-3.3.1 branch 5 times, most recently from ddb0c39 to 64f60bb Compare May 17, 2024 01:58
@MikeMcQuaid MikeMcQuaid force-pushed the portable-ruby-3.3.1 branch 3 times, most recently from 9576a7b to 727cf5e Compare May 17, 2024 03:32
Base automatically changed from portable-ruby-3.3.1 to master May 17, 2024 03:42
@MikeMcQuaid MikeMcQuaid force-pushed the vernier branch 2 times, most recently from 5a7655b to 44744a8 Compare May 17, 2024 06:07
@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review May 17, 2024 14:50
It's the newest great profiler for Ruby.
@carlocab
Copy link
Member

How slow/fast is this meant to be? I've been staring at this for the past 5 minutes or so:

❯ brew prof --vernier -- deps --tree --include-build --include-test --annotate ffmpeg
Fetching gem metadata from https://rubygems.org/.......
Fetching ruby-prof 1.7.0
Fetching sorbet-runtime 0.5.11383
Fetching stackprof 0.2.26
Fetching vernier 1.0.1
Installing vernier 1.0.1 with native extensions
Installing stackprof 0.2.26 with native extensions
Installing sorbet-runtime 0.5.11383
Installing ruby-prof 1.7.0 with native extensions
Bundle complete! 38 Gemfile dependencies, 40 gems now installed.
Bundled gems are installed into `../../../../../../../opt/homebrew/Library/Homebrew/vendor/bundle`
starting profiler with interval 500

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't gotten this to work, but it doesn't seem to break anything, so fine with me.

@MikeMcQuaid
Copy link
Member Author

@carlocab Thanks! Let's merge and iterate. Hopefully can help you debug this 🔜

@MikeMcQuaid MikeMcQuaid merged commit 5a24eb6 into master May 20, 2024
30 checks passed
@MikeMcQuaid MikeMcQuaid deleted the vernier branch May 20, 2024 15:35
@MikeMcQuaid
Copy link
Member Author

I've been staring at this for the past 5 minutes or so:

I saw it hang a few times, unsure why. It worked if I Ctrl-Cd and tried again.

Probably worth us figuring this out as it's way better than ruby-prof etc.

@carlocab
Copy link
Member

I saw it hang a few times, unsure why. It worked if I Ctrl-Cd and tried again.

Did this several times and didn't get anywhere, sadly.

@github-actions github-actions bot added the outdated PR was locked due to age label Jun 20, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants