Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

context: fix original context not being restored #17654

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

EricFromCanada
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #17641: if Thread.current[:context] returns nil, the original context won't be saved and restored, so use self.current which accounts for that possibility.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @EricFromCanada!

@MikeMcQuaid MikeMcQuaid merged commit e12d25d into master Jul 8, 2024
25 checks passed
@MikeMcQuaid MikeMcQuaid deleted the context-restore-fix branch July 8, 2024 18:15
@Bo98
Copy link
Member

Bo98 commented Jul 8, 2024

Makes sense. Though for the Thread.current[:context] = old_context in the ensure block we do want the original thread-context rather than the global one so that Context.current = whatever works after a with_context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supplying --fetch-HEAD to brew outdated hides version details
3 participants