Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brew bump: do not call repology by default #17740

Merged
merged 2 commits into from
Jul 14, 2024

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Jul 14, 2024

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This is a follow up of #17021 : by running brew bump without other argument, the command would still query repology on all formulae then hide the repology information in the output. I spotted that due to some formulae having matching formula version and livecheck version without any mention that they were up to date. There was an extra comparison with the repology version.

This PR adds the --eval-all flag to make this behaviour explicit. It also stops calling repology by default.

@Rylan12
Copy link
Member

Rylan12 commented Jul 14, 2024

Now, this check seems irrelevant and I think it can be removed:

if formulae_and_casks.present?
handle_formula_and_casks(formulae_and_casks)
else
handle_api_response
end

And potentially we have no need for handle_api_response anymore?

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks @Moisan!

Please answer/address @Rylan12's comment first.

@Moisan
Copy link
Member Author

Moisan commented Jul 14, 2024

After discussion with @nandahkrishna , I removed the handle_api_response which was first listing all formulae available on repology. I added the --repology flag to allow to query repology since it's not blocked anymore.

Copy link
Member

@nandahkrishna nandahkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks!

@nandahkrishna nandahkrishna merged commit 9f3c404 into Homebrew:master Jul 14, 2024
24 checks passed
@Moisan Moisan deleted the brew_bump_all branch July 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants