-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Add -gcflags
to std_go_args
#18615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable in case we need to add standard gcflags in the future.
Some additional context:
Cheers! 🧡 🍺 |
Usually when it comes to extra arguments the preferred way to do it is e.g. system "go", "build", *std_go_args, "-extraflag", "-extraflag2" The reason system "go", "build", *std_go_args, "-ldflags=-abc" would actually override the ldflags in So I'm ok adding arguments like this for flags that behave like |
Sounds great, 100% agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, thanks!
Thank you! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?This change adds support for compiler flags (
gcflags
) as standard arguments in Go builds, enabling better control over compilation behavior.So, instead of:
You can pass them as arguments: