Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show texture image in texture selector #278

Closed
wants to merge 4 commits into from
Closed

Show texture image in texture selector #278

wants to merge 4 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 22, 2023

The basics should be there, but i think it needs some more cleaning up. 😄

@Dgzt
Copy link
Collaborator

Dgzt commented Nov 23, 2023

Looks good to me, thank you.

@Dgzt Dgzt linked an issue Nov 23, 2023 that may be closed by this pull request
Show texture image in texture selector widget #246
Open
@Dgzt Dgzt added the enhancement New feature or request label Nov 23, 2023
@Dgzt
Copy link
Collaborator

Dgzt commented Nov 23, 2023 •
edited
Loading

As I see, this PR changes everywhere the asset selection from name of asset to "image" of asset (e.g.: texture change, material change, etc), but I like it.

@ghost
Copy link
Author

ghost commented Nov 25, 2023 •
edited by ghost
Loading

As I see, this PR changes everywhere the asset selection from name of asset to "image" of asset (e.g.: texture change, material change, etc), but I like it.

I might have changed more than i intended, but maybe it is fine anyway. 😅

@ghost ghost force-pushed the show-texture-image-in-texture-selector branch from d85785f to bdc5fb6 Compare November 30, 2023 17:49
@ghost ghost mentioned this pull request Nov 30, 2023
Closed
@ghost
Copy link
Author

ghost commented Nov 30, 2023 •
edited by ghost
Loading

I moved the changes related to #279 into #281. I apologize for mixing these topics.

JamesTKhan
JamesTKhan requested changes Jan 31, 2024
View reviewed changes
Copy link
Owner

@JamesTKhan JamesTKhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. I apologize for the delay in reviewing, alot of things going on at home the last several months. I was testing out the PR but found an issue. When there are more textures in a project, I can't seem to scroll and the None button is overlapping the textures as well

301232044-859e4c42-c057-4f28-b776-c7ca5e4b781b

@ghost
Copy link
Author

ghost commented Feb 4, 2024

I apologize for the delay in reviewing

Dont worry about it!

I think the issues you mentioned are fixed now. There were some conflicts with the changes related to #282. I would appreciate if you could check if everything is still working as intended.

@ghost ghost requested a review from JamesTKhan February 4, 2024 14:34
@ghost ghost closed this by deleting the head repository Oct 26, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesTKhan JamesTKhan Awaiting requested review from JamesTKhan

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show texture image in texture selector widget
2 participants
@Dgzt @JamesTKhan