Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CurrencyProviderSpi.getCurrencies should specify first criteria wins #116

Open
marschall opened this issue Jul 19, 2019 · 0 comments
Open

CurrencyProviderSpi.getCurrencies should specify first criteria wins #116

marschall opened this issue Jul 19, 2019 · 0 comments
Milestone
.Next

Comments

@marschall
Copy link
Member

marschall commented Jul 19, 2019 •
edited
Loading

CurrencyQuery allows to specify several criteria eg. currency codes and countries eg. "USD" and "es_EC"
However javax.money.spi.CurrencyProviderSpi#getCurrencies(CurrencyQuery) does not specify what happens when multiple criteria are set. JDKCurrencyProvider currently behaves like this:

  1. If a currency code is specified search by currency code, otherwise
  2. If a country is specified search by country, otherwise
  3. If a numeric code is specified search by numeric code, otherwise
  4. return everything
@marschall marschall changed the title CurrencyQuery should specify criteria are ORed CurrencyQuery should specify first criteria wins Jul 19, 2019
@marschall marschall changed the title CurrencyQuery should specify first criteria wins CurrencyProviderSpi.getCurrencies Jul 19, 2019
@marschall marschall changed the title CurrencyProviderSpi.getCurrencies CurrencyProviderSpi.getCurrencies should specify first criteria wins Jul 19, 2019
@keilw keilw added this to the .Next milestone Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
.Next
Development

No branches or pull requests
2 participants
@keilw @marschall