Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Published license identifier is not compliant with the SPDX license list #143

Open
mervyn-mccreight opened this issue Nov 14, 2022 · 4 comments
Milestone

Comments

@mervyn-mccreight
Copy link

As for now the license is getting published as Apache 2 License but according to https://spdx.org/licenses/Apache-2.0.html the SPDX-identifier would be Apache-2.0.

It would be nice to align it to the SPDX-identifier, because this makes it easier for tools like e.g. Gradle plugins to detect the used license by relying on the SPDX license identifiers.

The published URL to the license is also not correct, as it just references as LICENSE.txt which is not an absolute path to the license file. IMO best would be to link to the official template of the used license, e.g. https://spdx.org/licenses/Apache-2.0.html or https://www.apache.org/licenses/LICENSE-2.0 respectively.

@keilw keilw added this to Backlog Nov 14, 2022
@keilw keilw added this to the .Next milestone Nov 14, 2022
@keilw keilw removed this from Backlog Nov 14, 2022
@keilw
Copy link
Member

keilw commented Nov 14, 2022

Thanks but this is a tiny thing, plus Github recognizes the Apache-2.0 license, and the Enforcer plugin as part of the build also does. If there is either a critical security or bugfix or a new major version like MR2 or 2.0 we'll look into it.

@stokito
Copy link
Member

stokito commented Apr 25, 2023

Technically speaking we also need to add a NOTICE file https://github.com/JavaMoney/jsr354-api/blob/master/LICENSE.txt#L179

@stokito
Copy link
Member

stokito commented Apr 25, 2023

@mervyn-mccreight "As for now the license is getting published as Apache 2 License" sorry could you please elaborate where you see it?

@mervyn-mccreight
Copy link
Author

Sure.
You can see it in the published maven artifact (e.g. at mvnrepository.com).

See here: https://github.com/JavaMoney/jsr354-api/blob/master/pom.xml#L202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants