Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard to find default wallpapers #3

Open
lukors opened this issue Dec 14, 2021 · 11 comments
Open

Hard to find default wallpapers #3

lukors opened this issue Dec 14, 2021 · 11 comments

Comments

@lukors
Copy link
Contributor

lukors commented Dec 14, 2021

I'd like to use default wallpapers with Switcher. I don't know where on my computer they are. It would be great if Switcher made it easy to get to them.

@JeysonFlores
Copy link
Owner

What's a "default wallpaper"?

@lukors
Copy link
Contributor Author

lukors commented Dec 15, 2021

The ones that come with elementary OS, these ones:

Skärmbild från 2021-12-15 23-55-17

@JeysonFlores
Copy link
Owner

Oh, I get it then. What about default wallpapers folder being the default folder of selecting wallpapers?

@lukors
Copy link
Contributor Author

lukors commented Dec 15, 2021

That would be a definite improvement!

@JeysonFlores JeysonFlores added the enhancement New feature or request label Dec 15, 2021
@lukors
Copy link
Contributor Author

lukors commented Dec 15, 2021

I think the "right" way to do this would be to do it like the regular background picker does it (the one shown in the picture above), however that is. :)

But defaulting to the wallpapers folder would be an easy way to get like 80% of the same functionality.

@JeysonFlores
Copy link
Owner

Drastic UI proposals will be considered when a new version is being planned.

@JeysonFlores
Copy link
Owner

According to the documentation at least one of these methods' functionality sets the default folder in the dialog:
image

However none of them work (at least for me). Can you try the code of the branch issue3 and say if it works for you?

@lukors
Copy link
Contributor Author

lukors commented Dec 16, 2021

I tested it and it doesn't work for me either.


On this page in the documentation they advise against using set_current_folder:

Note that old versions of the file chooser’s documentation suggested using set_current_folder in various situations, with the intention of letting the application suggest a reasonable default folder. This is no longer considered to be a good policy, as now the file chooser is able to make good suggestions on its own. In general, you should only cause the file chooser to show a specific folder when it is appropriate to use set_filename, i.e. when you are doing a Save As command and you already have a file saved somewhere.

Could this behaviour be blocked in elementary OS?


Maybe we're better off abandoning this seemingly simple path, and instead creating a simple interface to pick from existing wallpapers in the two wallpaper locations, and then having a button to add another one.

Essentially like the background picker in the Desktop Plug.
image

Might be able to use some of the code from this plug.

@lukors
Copy link
Contributor Author

lukors commented Dec 16, 2021

This feels important to me, so I'll look into adding this.

@lukors
Copy link
Contributor Author

lukors commented Dec 16, 2021

I've looked into this a bit, but I'm giving up for now.

@JeysonFlores
Copy link
Owner

I've read the code of the desktop plug and even you can move a lot of them it has some quirky things about the way it manages and sets the backgrounds so it'll need some code adaptation. I'll move this to the version2 flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants