Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time of disposal after swipe depends on where it is released #9

Open
InfiniteTabs opened this issue Feb 28, 2021 · 2 comments
Open
Labels
T: Fix Type: :bug: Bug Fixes

Comments

@InfiniteTabs
Copy link
Contributor

InfiniteTabs commented Feb 28, 2021

Hi!

First of all, great work with this package!

I have experienced that the disposal has a long delay before being disposed which seems to be related to where it was released on the x-axis. The typical use case is that the user will swipe to dismiss it, but if they are too fast trying to opening another page nothing happens (since it has not been disposed yet).

I tried to demonstrate it here: https://vimeo.com/517835528

As seen in the video it is first released near to the right => it gets disposed immediately according to the log.
The second time the page is swiped and released far to the left => according to the log it gets disposed with a delay after it has disappeared.

Best regards

@InfiniteTabs InfiniteTabs added the T: Fix Type: :bug: Bug Fixes label Feb 28, 2021
@JonasWanke
Copy link
Owner

Thanks for the detailed description and even a video! SwipeablePageRoute actually inherits from Flutter's built-in CupertinoPageRoute (well, before v0.2.0 it just copied the code) and only adds parameters to control from where the back gesture can start. It seems like this problem is reproducible with CupertinoPageRoute, so I recommend filing an issue there.

@InfiniteTabs
Copy link
Contributor Author

InfiniteTabs commented Mar 9, 2021

Thanks for the reply, I had no idea it was a problem with the built in code.

I've continued the discussion here: flutter/flutter#73026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Fix Type: :bug: Bug Fixes
Projects
None yet
Development

No branches or pull requests

2 participants