Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter apps using this plugin can no longer run in the master channel #22

Open
volgin opened this issue Feb 26, 2023 · 6 comments
Open

Comments

@volgin
Copy link

volgin commented Feb 26, 2023

This plugin has a deprecated code that prevents building Flutter apps:

Failed to build iOS app
Error (Xcode): ../../.pub-cache/hosted/pub.dev/liquid_progress_indicator-0.4.0/lib/src/liquid_circular_progress_indicator.dart:48:46: Error: The getter 'accentColor' isn't defined for the class 'ThemeData'.

The solution is to migrate from accentColor to secondary color, as explained in the documentation:

Code before migration:

Color myColor = Theme.of(context).accentColor;

Code after migration:

Color myColor = Theme.of(context).colorScheme.secondary;
@volgin
Copy link
Author

volgin commented Mar 19, 2023

Now this plugin does not compile in the beta channel.

@NonymousMorlock
Copy link

now it doesn't compile on the stable channel either

@abdelaziz-mahdy
Copy link

i am using the fix in #23

in pubspec

  liquid_progress_indicator: # ^0.4.0
    git:
      url: https://github.com/Jollastro/liquid_progress_indicator

@NonymousMorlock
Copy link

Thanks a lot

@arnab
Copy link

arnab commented May 25, 2023

FYI, the PR for this fix is out (thanks @Jollastro): #23.

@Pablo-Aldana
Copy link

Hi! Seeing the urgency of the issue, I have created a fork with the fixed and uploaded a new package to pub.dev in case you'd like to use it.

Liquid Progress Indicator Dart3 compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants