From ecbc4931a47075716c41b0d85d553872e7edd805 Mon Sep 17 00:00:00 2001 From: Pierre Jacquier Date: Thu, 2 Jan 2025 17:17:08 -0500 Subject: [PATCH] Add auto-retries to macOS build notarization (#4892) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * Add DEBUG=electron-notarize* to build-apps * Force IS_RELEASE: true * Temp: Disable version setting based on tag * Remove deprecated notarize.teamId and add retry logic * Revert "Remove deprecated notarize.teamId and add retry logic" This reverts commit 6ff98d784d77cc29a2b7b5da10327a8d1ff01572. * Retry only on macOS * Better retry logic for macOS * Use nick-fields/retry * Clean up Temp: commits for PR * Clean up * A snapshot a day keeps the bugs away! 📷🐛 (OS: namespace-profile-macos-8-cores) * Trigger CI --------- Co-authored-by: github-actions[bot] --- .github/workflows/build-apps.yml | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-apps.yml b/.github/workflows/build-apps.yml index c0a65f7969..c4ab61d2ae 100644 --- a/.github/workflows/build-apps.yml +++ b/.github/workflows/build-apps.yml @@ -173,7 +173,13 @@ jobs: CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }} WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }} - run: yarn electron-builder --config --publish always + DEBUG: "electron-notarize*" + # TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures + uses: nick-fields/retry@v3.0.0 + with: + timeout_minutes: 10 + max_attempts: 3 + command: yarn electron-builder --config --publish always - name: List artifacts in out/ run: ls -R out @@ -228,7 +234,13 @@ jobs: CSC_KEY_PASSWORD: ${{ secrets.APPLE_CERTIFICATE_PASSWORD }} CSC_KEYCHAIN: ${{ secrets.APPLE_SIGNING_IDENTITY }} WINDOWS_CERTIFICATE_THUMBPRINT: ${{ secrets.WINDOWS_CERTIFICATE_THUMBPRINT }} - run: yarn electron-builder --config --publish always + DEBUG: "electron-notarize*" + # TODO: Fix electron-notarize flakes. The logs above should help gather more data on failures + uses: nick-fields/retry@v3.0.0 + with: + timeout_minutes: 10 + max_attempts: 3 + command: yarn electron-builder --config --publish always - uses: actions/upload-artifact@v4 if: ${{ env.IS_RELEASE == 'true' }}