Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PC321 / OWON: Cluster definition with wrong ID #1278

Closed
renaiku opened this issue Dec 29, 2024 · 2 comments
Closed

PC321 / OWON: Cluster definition with wrong ID #1278

renaiku opened this issue Dec 29, 2024 · 2 comments

Comments

@renaiku
Copy link
Contributor

renaiku commented Dec 29, 2024

zigbee-herdsman/src/zspec/zcl/definition/cluster.ts

Line 3307 in a6611e0

owonPercentChangeInPower: {ID: 0x5007, type: DataType.UINT8, manufacturerCode: ManufacturerCode.OWON_TECHNOLOGY_INC},

According PC231 clusters spec sheet, this should be 0x5008 and not 0x5007 (and 0x5007 is already used the line above)
@Koenkk
Copy link
Owner

Koenkk commented Dec 29, 2024

Could you make a PR to fix this? owonPercentChangeInPower doesn't seem to be used at the moment (so should be safe to change)

@renaiku
Copy link
Contributor Author

renaiku commented Dec 29, 2024 •
edited
Loading

Yes I will.
I'm currently working on the missing parts of this device in zigbee-herdsman-converters.

PR opened here: #1279

@renaiku renaiku mentioned this issue Dec 29, 2024
Merged
@renaiku renaiku closed this as completed Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Koenkk @renaiku