Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend swap stat rpcs to include burned fee #2329

Open
dimxy opened this issue Jan 27, 2025 · 0 comments
Open

Extend swap stat rpcs to include burned fee #2329

dimxy opened this issue Jan 27, 2025 · 0 comments
Labels
good first issue Good for newcomers improvement: RPC priority: high Important tasks that need attention soon.

Comments

@dimxy
Copy link
Collaborator

dimxy commented Jan 27, 2025

Currently swap stat rpcs: my_recent_swaps active_swaps swap_status for swpa V2 taker data do not include the burned part of dex fee (but only dex fee).
However taker user may be interested in getting total spent fee in the swap statistics rpcs.
This is related to TPU (V2) swaps.

Info for fixing: add a property like Option<burn_dex_fee> to MySwapForRpc and extend SELECT_MY_SWAP_V2_FOR_RPC_BY_UUID query
@dimxy dimxy mentioned this issue Jan 27, 2025
Open
12 tasks
@shamardy shamardy added priority: high Important tasks that need attention soon. good first issue Good for newcomers labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers improvement: RPC priority: high Important tasks that need attention soon.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dimxy @shamardy