P2PK input cause taker fee validation to fail

[Alrighttt]

Using a P2PK("pay to public key" or <pubkey> OP_CHECKSIG input for sending taker fee will result in maker validation of the taker fee to fail with the following error.

{
    "timestamp": 1738765718666,
    "event": {
        "type": "TakerFeeValidateFailed",
        "data": {
            "error": "maker_swap:777] utxo_common:2029] utxo_common:1970] None instruction 1 of script Script { data: 47304402200d8864318a9d6c1fcbfa1819010214c42dc1f9e82ca55059121e48f478f3e11c0220609552cf06cf55d767d92fefc0753fdde8b4924866034054bd38b081c6862fca01 }"
        }
    }
},

komodo-defi-framework/mm2src/coins/utxo/utxo_common.rs

Line 1971 in ff0eefc

None => return ERR!("None instruction 1 of script {:?}", script),

The taker fee validation is attempting to validate that all inputs have been signed by the taker's pubkey. If any of these inputs are P2PK(as opposed to P2PKH or P2WPKH), the validation will fail unexpectedly.

If this check will remain in place, the check_all_utxo_inputs_signed_by_pub function must account for P2PK inputs. This function should recalculate the sighash for this input and validate the provided signature against the expected public key.