Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It is impossible to use any reading app without custom background and text color setting. The current PR code is not complete. Feel free to reject this PR.
However, this change has demonstrated the method on changing background color using mupdf API. The current implementation is to hard code a color.
If you like this change, please continue the work to expend qml to allow user to input hex color code and be passed down to
page_controller.cpp
line:63
for a completed feature.The text color, on the other hand, is impossible to change with this dependency choice (mupdf). So, I have gave up on using this app for eBook reading. This PR is only to document the effort that I have spend to fix the issue I initiated.
Related Tickets & Documents
How Has This Been Tested?
Compiled locally on Windows using Qt 6.7.2 + MSVC 2019 with self hosted server.
Added or Updated Tests?
Checklist: