Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pdp Logged Channel Names #159

Open
scarmain opened this issue Jan 13, 2025 · 0 comments
Open

Pdp Logged Channel Names #159

scarmain opened this issue Jan 13, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@scarmain
Copy link

Is your feature request related to a problem? Please describe.
I would like to be able to add channel names to PDP current logs. Ids 0-23 just don’t help with diagnostics, then having to have a dictionary to look up channel names too.

Describe the solution you'd like
On construction of the PDP logger, be able to pass in a string [] of names that describe each channel with descriptive names.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Also, it would be more efficient to use the Pdp.getAllCurrents() now. If you follow the JNI source, each current call needs to send a message on the CAN bus and wait for response. getAllCurrents() will do it in a more optimized way, reducing traffic to 4-6 messages. (This is a new function for 2025 WpiLib, I implemented it)

@scarmain scarmain added the enhancement New feature or request label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant