Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there PHP8.1 compatibility work in the plan? #26

Open
adarshkhatri opened this issue Nov 17, 2022 · 3 comments
Open

Is there PHP8.1 compatibility work in the plan? #26

adarshkhatri opened this issue Nov 17, 2022 · 3 comments

Comments

@adarshkhatri
Copy link

adarshkhatri commented Nov 17, 2022

Since moving to PHP 8.1, we are having issues regarding the Deprecated return type errors. Lots of them.

Is there PHP8.1 compatibility work in the plan?

One of the error:

Fatal error: During inheritance of IteratorAggregate: Uncaught Exception: Deprecated Functionality: Return type of Metabor\NamedCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /vendor/metabor/statemachine/src/Metabor/NamedCollection.php on line 53 in /vendor/magento/framework/App/ErrorHandler.php:61
Stack trace:

@Metabor
Copy link
Owner

Metabor commented Nov 18, 2022 via email

@adarshkhatri
Copy link
Author

Fatal error: During inheritance of IteratorAggregate: Uncaught Exception: Deprecated Functionality: Return type of Metabor\NamedCollection::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /vendor/metabor/statemachine/src/Metabor/NamedCollection.php on line 53 in /vendor/magento/framework/App/ErrorHandler.php:61
Stack trace:

@Metabor
Copy link
Owner

Metabor commented Sep 14, 2023

I pulled the changes @florentintyroola made into this branch.
https://github.com/Metabor/Statemachine/tree/php8.1
But have not tested yet.
Will make a new version (3.0) if this workes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants