-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't prefix the app name with nativescript #6
Comments
Agreed - will do (Makes sense for apps for this to be purely optional). Curious on your thoughts with libs - as the lib generator also will use a prefix? We've always preferred to have some platform in the organization (around shared code) to be extra clear (especially within large cross platform workspaces). The problem without (regarding libs) is you could have:
However it's not clear at all what UI that's for? Is it for web, nativescript, ionic, vue, what? |
I already use my own prefixes everywhere for every thing--I use ng, ns, py, ...etc., so my actual context is using ns instead of nativescript, which I had to achieve by manually editing the workspace. So, as much as I personally am huge goer for prefixing libs and apps, I'm calling for it to be optional to allow the developer choose the preferred prefix. |
What about a option on the generators "affix"? The default would be set to Then teams could set it to ns if that is what they prefer, or set it empty string to omit it. Then the plugin was append or prepend it depending on if groupByName was used or omitted. |
@AgentEnder, I applaud this approach. Why, yes, it makes sense as it also streamlines single team/org preferences for the prefix. |
alternative to discussion in issue NativeScript#6
alternative to discussion in issue NativeScript#6
I'm also interested in having this as an option. I made 2 commits (as seen above) that allows this to happen for app and lib creation. @AgentEnder I attempted to add a new property named 'affix' to the schematic but quickly realized that may be confusing for developers of this repo since there is already a property named 'prefix' that is used for However, there is a |
As
README
explains:I would suggest that the prefix should be optional, and
groupByName
option should act on this, not the other way around.The text was updated successfully, but these errors were encountered: