Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported videos missing video track (audio only) #38

Open
GrandPoohBear opened this issue Jan 10, 2022 · 2 comments
Open

Exported videos missing video track (audio only) #38

GrandPoohBear opened this issue Jan 10, 2022 · 2 comments

Comments

@GrandPoohBear
Copy link

In some cases, we have seen videos that are exported by NextLevelSessionExporter that seem to consistently drop the video tracks entirely, leaving just an audio track in the output file. Luckily, it's fairly easy to detect the problem - looking at the ratio of file sizes between compressed and uncompressed files leaves completely silly compression ratios.

We're working on getting a reliable repro case, but it's possible it has something to do with videos that came from Snapchat.

When I know more, I can post back, but wondering if others have seen anything similar, and if there's a way to prevent it from happening?
@dac09
Copy link

dac09 commented Feb 4, 2022

Hi @GrandPoohBear did you find the root cause for this by any chance?

From our observations, we are seeing this happening on x86/x64 (we're building a universal binary) - but not on m1 macs.

I wonder if this might help you narrow down the cause.

@GrandPoohBear
Copy link
Author

Interesting color, but no, unfortunately! We're seeing it on iOS. It will happen consistently with one of our testers with one source movie on one device, but haven't even been able to repro with the same source on other devices, or other similar sources on the same device 🤷🏻‍♂️

@GrandPoohBear GrandPoohBear mentioned this issue Feb 11, 2022
Closed
Developer-Ecosystem-Engineering added a commit to Developer-Ecosystem-Engineering/NextLevelSessionExporter that referenced this issue Jun 2, 2022
@Developer-Ecosystem-Engineering
Buffers in pool may not always point at the Metal video compositors o…
5f6df63 
…utput

We received a report of black frames in an applications video content once it was encoded with NextLevel.

Investigation revealed a similar issue as NextLevel#38.

It appears NextLevelSessionExporter is pulling buffers from the pool that was created, and sending those buffers back to the API. The  assumption a buffer pulled from that pool will contain the output of the Metal video compositor is not always correct.

This change will pass the pixelBuffer directly, or use the toBuffer if a renderHandler exists.
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GrandPoohBear @dac09