Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discord with Vencord not working/ app is damaged #355950

Open
ojsef39 opened this issue Nov 14, 2024 · 9 comments
Open

Discord with Vencord not working/ app is damaged #355950

ojsef39 opened this issue Nov 14, 2024 · 9 comments
Labels
0.kind: bug Something is broken

Comments

@ojsef39
Copy link

ojsef39 commented Nov 14, 2024

Describe the bug

The Discord App is damaged when installed with Vencord.

Thanks in advance for looking into this :)

Steps To Reproduce

Steps to reproduce the behavior:

  1. Install Discord like this:
{ pkgs, lib, vars, ... }: 
{
  environment.systemPackages = with pkgs; [
    (discord.override {
      withVencord = true;
    })  # Discord with Vencord
  ];
}
  1. Open Discord

Expected behavior

I expected the app to open normally as described here:
#259297 (comment)

Screenshots

image

Additional context

I tried different scenarios like installing both the override and discord, i removed every remains of discord and installed only discord and then afterward added the override and more, but everything i tried doesn't seem to work

Metadata

 - system: `"aarch64-darwin"`
 - host os: `Darwin 24.2.0, macOS 15.2`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/Users/user/.nix-defexpr/channels/nixpkgs`

Notify maintainers

@Artturin
@donatello
@Infinidoge
@jopejoe1
@Scrumplex


Note for maintainers: Please tag this issue in your PR.


Add a 👍 reaction to issues you find important.

@ojsef39 ojsef39 added the 0.kind: bug Something is broken label Nov 14, 2024
@Scrumplex
Copy link
Member

CC @FlafyDev @NotAShelf @DontEatOreo for Vencord

I don't have a darwin machine to test this sadly.

@DontEatOreo
Copy link
Member

Try to open it so it fails, then

System Settings -> Privacy -> Scroll all way down -> Open Anyway -> Enter your user password

@ojsef39
Copy link
Author

ojsef39 commented Nov 14, 2024

Try to open it so it fails, then

System Settings -> Privacy -> Scroll all way down -> Open Anyway -> Enter your user password

Thank you that worked, it opens now, but since it updated on launch there is no vencord.

Could you please update the discord package? Thank you very much in advance! (should i open a separate issue for that?)

And i highly appreciate your fast responses! Didn't think i get an answer that fast lol

@DontEatOreo
Copy link
Member

DontEatOreo commented Nov 14, 2024

Thank you that worked, it opens now, but since it updated on launch there is no vencord.

When you open Discord did it ask you to enter your password (AFTER the prompt in system settings) in order to update Discord?

If that's the case, then you will have to log out of macOS, log in, then sudo nix store delete /nix/store/....-Discord and rebuild your system to download Discord again

To avoid all of this mess in the future, make sure to run Discord first from the terminal (by just running discord) so it runs the Python script (https://github.com/NixOS/nixpkgs/blob/7421ff3aa29d1a7da7bf0302b9e640cab064fb67/pkgs/applications/networking/instant-messengers/discord/disable-breaking-updates.py) that adds SKIP_HOST_UPDATE to settings.json (in ~/Library/Application\ Support/discord), so you don't get "tricked" into accidentally updating Discord on Nix and breaking your Vencord install

@DontEatOreo
Copy link
Member

Could you please update the discord package?

There's already a PR (#355721)

@ojsef39
Copy link
Author

ojsef39 commented Nov 14, 2024

If that's the case, then you will have to log out of macOS, log in, then sudo nix store delete /nix/store/....-Discord and rebuild your system to download Discord again

Ahh I see, okay, I will try that :) Just got some issue about the store still being active (even after logout)

To avoid all of this mess in the future, make sure to run Discord first from the terminal (by just running discord) so it runs the Python script (https://github.com/NixOS/nixpkgs/blob/7421ff3aa29d1a7da7bf0302b9e640cab064fb67/pkgs/applications/networking/instant-messengers/discord/disable-breaking-updates.py) that adds SKIP_HOST_UPDATE to settings.json (in ~/Library/Application\ Support/discord), so you don't get "tricked" into accidentally updating Discord on Nix and breaking your Vencord install

good to know, will do that, thanks for the info :)

@ojsef39
Copy link
Author

ojsef39 commented Nov 14, 2024

So ive tried it now and it doesnt seem to work for me.
The issue is probably that i cant open discord again from the terminal after i hit "open anyway" in settings, i have to open it with the open button and then it will update

🚀 discord
[Vencord] Starting up...
[Vencord] Loading original Discord app.asar
Discord 0.0.305
blackbox: 2024-11-14T19:49:30.732Z 0

----------------------------------------------
Starting app.
Starting updater.
MacOS major version was 24, minimum supported version for future updates is 19

@ojsef39
Copy link
Author

ojsef39 commented Nov 14, 2024

ah i see, you hit cancel, wait and then it starts but now i see this:
image
i guess thats related to #334141

maybe i should just use nixcord, but big big thanks to you guys for responding so fast!

@DontEatOreo
Copy link
Member

So ive tried it now and it doesnt seem to work for me. The issue is probably that i cant open discord again from the terminal after i hit "open anyway" in settings, i have to open it with the open button and then it will update

In that case, you can first open it via System Settings, and when you are prompted again for the password in Discord to update, just cancel it, close Discord, and then launch it from Terminal.

It should start with:

[Nix] Disabling updates already done
[Vencord] Starting up...
[Vencord] Loading original Discord app.asar
...

I think the crash is related to discord updates, breaking some of Vencord's regex, it should be fix in v1.10.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

3 participants