Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"silent" severity items showing up #589

Open
felschr opened this issue May 19, 2020 · 1 comment
Open

"silent" severity items showing up #589

felschr opened this issue May 19, 2020 · 1 comment

Comments

@felschr
Copy link

felschr commented May 19, 2020

Using the new .editorconfig integration, I noticed that items with severity set to silent & suggestion still show up.
I guess suggestions are probably intended to show up but silent items definitely shouldn't.
The same config works fine with omnisharp-vscode.

@nickspoons
Copy link
Member

silent items are tricky. They are returned as LogLevel: Hidden from O#roslyn, and we did attempt to always hide these at one point. However this turned out to be a mistake, because some diagnostics always appear to be marked as Hidden, for example "unnecessary usings", see #497

suggestion diagnostics are returned as LogLevel: Info from O#roslyn and are given the location type value I which ALE interprets as Information, so these are generally marked differently by ALE. silent/Hidden diagnostics are given the location subtype value Style which ALE also can mark differently.

To have diagnostics hidden completely, we currently rely on the g:OmniSharp_diagnostic_overrides dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants