Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we need ShoopingCartId in AddItemViewModel.cs (OCC-305) #511

Open
infofromca opened this issue Nov 29, 2024 · 1 comment
Open

we need ShoopingCartId in AddItemViewModel.cs (OCC-305) #511

infofromca opened this issue Nov 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@infofromca
Copy link
Contributor

infofromca commented Nov 29, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe

break the changes

Describe the solution you'd like

in future, you will need it

Describe alternatives you've considered

A clear and concise description of any alternative solutions or features you've considered.

Jira issue
@infofromca infofromca added the enhancement New feature or request label Nov 29, 2024
@github-actions github-actions bot changed the title we need ShoopingCartId in AddItemViewModel.cs we need ShoopingCartId in AddItemViewModel.cs (OCC-305) Nov 29, 2024
@sarahelsaig
Copy link
Contributor

I don't think you will need it. AddItemViewModel is only used in the ~/api/shoppingcart/{shoppingCartId?} endpoint, where you pass in shopping cart ID as part of the route.
Adding a property to a type is also not a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@infofromca @sarahelsaig