You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've checked for duplicate open and closed issues by using the search function of the issue tracker
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
When PR #8271 "Change default Boss Config from None to Pinnacle" goes live, build-file consumers (pobb.in etc) will likely have difficulty discerning old build files from new, and will therefore not use the correct default for the boss-type setting. This may adversely affect consumers that rely on knowing the boss-type setting.
Currently there is no guaranteed explicit indication of the boss-type setting in the build-file format, which can be in one of these five states:
<Input name="enemyIsBoss" string="None"/>
<Input name="enemyIsBoss" string="Boss"/>
<Input name="enemyIsBoss" string="Pinnacle"/>
<Input name="enemyIsBoss" string="Uber"/>
No "enemyIsBoss" tag = default setting
In PoB 2.48.2 the default setting (no tag) = "None". In the current dev build the default setting (no tag) = "Pinnacle".
Describe the solution you'd like
So far I've only requested input from pobb.in creator @Dav1dde. He indicated his preference is for the addition a simple (integer) file-format-version number to the build file, to be incremented whenever a breaking-change is made to it.
I'm happy to reach out to other developers should maintainers require more input/feedback.
Describe alternatives you've considered
Always write the boss-type tag to the build file (no missing tag).
Write a file-format version number to the build file that is manually incremented on breaking-change.
Write the version-number of the PoB executable to the build file.
Attempt to discern the boss-type from other tags in the build-file [further investigation needed].
Additional context
No response
The text was updated successfully, but these errors were encountered:
Check for duplicates
What platform are you running Path of Building on?
Windows
Is your feature request related to a problem?
When PR #8271 "Change default Boss Config from None to Pinnacle" goes live, build-file consumers (pobb.in etc) will likely have difficulty discerning old build files from new, and will therefore not use the correct default for the boss-type setting. This may adversely affect consumers that rely on knowing the boss-type setting.
Currently there is no guaranteed explicit indication of the boss-type setting in the build-file format, which can be in one of these five states:
<Input name="enemyIsBoss" string="None"/>
<Input name="enemyIsBoss" string="Boss"/>
<Input name="enemyIsBoss" string="Pinnacle"/>
<Input name="enemyIsBoss" string="Uber"/>
In PoB 2.48.2 the default setting (no tag) = "None". In the current dev build the default setting (no tag) = "Pinnacle".
Describe the solution you'd like
So far I've only requested input from pobb.in creator @Dav1dde. He indicated his preference is for the addition a simple (integer) file-format-version number to the build file, to be incremented whenever a breaking-change is made to it.
I'm happy to reach out to other developers should maintainers require more input/feedback.
Describe alternatives you've considered
Additional context
No response
The text was updated successfully, but these errors were encountered: