Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate title and subtitle updates #2715

Open
IamMusavaRibica opened this issue Jul 27, 2022 · 5 comments
Open

Separate title and subtitle updates #2715

IamMusavaRibica opened this issue Jul 27, 2022 · 5 comments
Labels
new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f

Comments

@IamMusavaRibica
Copy link

Is your feature request related to a problem? Please describe.

My feature request is not related to a problem.

Describe the solution you'd like

There should be separate events for when title is changed and when the subtitle is changed. Currently, the event is fired when any of them change, but whether it was the title or the subtitle, is not specified. The 'title' event currently only knows about the new text, but changing that event would not make it backwards compatible. I open this issue for discussion on that

Describe alternatives you've considered

None

@IamMusavaRibica IamMusavaRibica added new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f labels Jul 27, 2022
@rob9315
Copy link
Contributor

rob9315 commented Jul 27, 2022

aside from that this event won't even be fired anymore for 1.19 and possibly below versions because title and subtitle has been separated into two packets

@rob9315
Copy link
Contributor

rob9315 commented Jul 27, 2022

backwards compatibility for this is probably not a big deal as i doubt anyone depended on this wrong behavior considering it's already been broken for quite a while, i propose the event should be split into title and subtitle, where each carries the expected data.

@IamMusavaRibica
Copy link
Author

#610 was when the current changes were made
For a bot I'm building, from the provided data, I can easily tell what is a title and what is a subtitle. But it is not different in the code, which is not practical

For the two events, in earlier version it was the same packet so those cases should be reviewed too

@rob9315
Copy link
Contributor

rob9315 commented Jul 27, 2022

yes, the old packet should trigger 'title' and 'subtitle' when appropriate

@SMEDjs
Copy link

SMEDjs commented Nov 9, 2024

#3498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Stage1 just created by someone new to the project, we don't know yet if it deserves an implementation / a f
Projects
None yet
Development

No branches or pull requests

3 participants