Unable to detect system locale

[sgkoishi]

TShock/docs/lang.md

Line 1 in a7360b6

TShock supports automatic language detection based on your system regional settings. If you want to override this, set the `TSHOCK_LANGUAGE` environment variable to a different language, or pass the `-lang` command line argument to change the language.

Theoretically TShock will detect the locale, but Terraria.Program.RunGame (orig_RunGame for OTAPI) calls LanguageManager.SetLanguage(GameCulture.DefaultCulture), which indirectly overwrite the CurrentUICulture to enUS.

Thus, the I18n.TranslationCultureInfo is always enUS if no TSHOCK_LANGUAGE, -lang or -language.

TShock/TShockAPI/I18n.cs

Line 63 in a7360b6

return CultureInfo.CurrentUICulture;

The call of SetLanguage happens before TShock and plugins, so the original value of CurrentUICulture is no longer available.

Some potential fix:

• Set the (private) field CultureInfo.s_currentThreadUICulture to null.
• Read the (private) property CultureInfo.GetUserDefaultCulture.
• Read the public property CultureInfo.InstalledUICulture.