Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] 15% Performance hit in Red Dead Redemption (Probably other titles too) (#16499) #16604

Closed
Yahfz opened this issue Jan 23, 2025 · 4 comments · Fixed by #16618 or #16656
Closed

Comments

@Yahfz
Copy link
Contributor

Yahfz commented Jan 23, 2025

PR that caused the regression: #16499

Log BEFORE the regression:

RPCS3.log

Log After the regression:

RPCS3.log

@AniLeo AniLeo changed the title [Regression] 15% Performance hit in Red Dead Redemption (Probably other titles too) [Regression] 15% Performance hit in Red Dead Redemption (Probably other titles too) (#16499) Jan 25, 2025
@kd-11 kd-11 assigned kd-11 and unassigned elad335 Jan 31, 2025
@kd-11
Copy link
Contributor

kd-11 commented Jan 31, 2025

Reopening since AMD users are still affected, Ref: #16643

@kd-11 kd-11 reopened this Jan 31, 2025
@AniLeo
Copy link
Member

AniLeo commented Jan 31, 2025

Ideally we should have some data from Ryzen CPUs on how big is the performance hit, pre-regression and with the current workaround

@kd-11
Copy link
Contributor

kd-11 commented Jan 31, 2025

The current solution just disables TSC on Ryzen completely which is horrible for performance, Ryzen has a much larger penalty from accessing QPC compared to intel (around 2x slower last time I measured)

@kd-11
Copy link
Contributor

kd-11 commented Jan 31, 2025

We know the TSC itself is fine, but calibration is difficult on some kernels without a patch. It should not be an issue on windows (different kernel) and on linux we can figure out TSCs with miscalibration and deal with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants