New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exception handling to LDAP server interactions #50

Open

A-Beck opened this issue Jul 26, 2019 · 0 comments

Labels

Collaborator

A-Beck commented Jul 26, 2019

If ldap.bind throws exception, it will not be handled appropriately.

We should add exception handling to make the LDAP code more robust when interacting during intermittent network / server issues.

Example - If ldap.bind times out/ connection refused/ etc, here [1], the built - in if /then logic will not handle the exception that is thrown.

[1] https://github.com/RedHatOfficial/miq-LDAP/blob/master/Automate/RedHatConsulting_LDAP/Integration/LDAP/StateMachines/Methods.class/__methods__/add_ldap_entry.rb#L165

A-Beck added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment