Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ExchangeRate dated #28

Open
RemyDuijkeren opened this issue May 15, 2015 · 1 comment
Open

Make ExchangeRate dated #28

RemyDuijkeren opened this issue May 15, 2015 · 1 comment
Labels

Comments

@RemyDuijkeren
Copy link
Owner

See the comments of #8 for the start issue.

ExchangeRate is/can't be dated at the moment. It would be nice to add the dates where the ExchangeRate is valid between.

Possible implementations could be:

// override of constructor
var fx = new ExchangeRate("EUR", "USD", 1.14m, dateFrom, dateTo)
var fx = new ExchangeRate("EUR", "USD", 1.14m, new Range<DateTime>(dateFrom, dateTo))
var fx = new ExchangeRate("EUR", "USD", 1.14m, new Period(dateFrom, dateTo))

// or be external
var fx = new ExchangeRate("EUR", "USD", 1.14m)
var datedFx = new Range<DateTime>(dateFrom, dateTo, fx);
var datedFx = new Period(dateFrom, dateTo, fx);
@RemyDuijkeren RemyDuijkeren added this to the v0.6.0 milestone Dec 8, 2015
@JayT82
Copy link

JayT82 commented Dec 11, 2015

In case of ExchangeRate, this issues gives a solution in the example code.
There might be some DataServices that give Exchange rates with a start date and validity duration.

@albertdh albertdh self-assigned this Dec 11, 2015
albertdh added a commit to albertdh/NodaMoney that referenced this issue Dec 23, 2015
Introducing a quote timestamp for making an exchange reate dated.
@albertdh albertdh mentioned this issue Dec 23, 2015
Closed
albertdh added a commit to albertdh/NodaMoney that referenced this issue Dec 23, 2015
@RemyDuijkeren RemyDuijkeren removed this from the v0.7.0 milestone Sep 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants