Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency code should be Enum, not a struct #86

Open
EynsherKiel opened this issue Jul 28, 2021 · 1 comment
Open

Currency code should be Enum, not a struct #86

EynsherKiel opened this issue Jul 28, 2021 · 1 comment

Comments

@EynsherKiel
Copy link

No description provided.

@EynsherKiel EynsherKiel changed the title Currency code should be Enum, not string Currency code should be Enum, not struct Jul 28, 2021
@EynsherKiel EynsherKiel changed the title Currency code should be Enum, not struct Currency code should be Enum, not a struct Jul 28, 2021
@gliljas
Copy link

gliljas commented Dec 16, 2021

There's very little benefit to that, and a couple of downsides. I agree it should not be a struct though. It should be a class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants