Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations #13

Open
Ruben2776 opened this issue Jun 16, 2020 · 4 comments
Open

Add translations #13

Ruben2776 opened this issue Jun 16, 2020 · 4 comments
Labels
good first issue Good for newcomers help wanted PR Welcome Pull requests are welcome

Comments

@Ruben2776
Copy link
Owner

Ruben2776 commented Jun 16, 2020

If you would like to translate PicView, or update an existing translation, please take a look at my guide:

  1. Make a fork of this repository
  2. Copy en.json from /Config/Languages and rename it to your two letter language code (wiki).
  3. Edit the right side values of the xx.json file to your language.
  4. Issue a pull request.

Note Shift and Alt are keyboard key names

If you want to test it
not required

  1. Open the project with the latest version of Visual Studio or Rider and have the latest .NET SDK installed.
  2. Start the app and change the language in the settings window F4.
@Ruben2776 Ruben2776 changed the title Add translation/language option Add translations Jul 22, 2020
@Ruben2776 Ruben2776 pinned this issue Jul 22, 2020
@Crystal-RainSlide
Copy link
Contributor

For xx-xx / xx_xx (zh-CN / zh_CN for example), should we use - or _?

@Ruben2776
Copy link
Owner Author

Ruben2776 commented Oct 9, 2020

It should be zh_CN then :)

Update: it should be zh-Ch with dashes instead #114

@sparmark
Copy link

I have translated the texts into Swedish, and have attached sv.json to this comment.

Forgive me for not adding it the proper way, but I am not so familiar with github yet. I hope you can still integrate it into your project.

sv.json

@Ruben2776
Copy link
Owner Author

@sparmark That's completely okay, thank you very much.

If anyone else has trouble with pull requests and want to update them manually, just remember to copy the latest iteration from the repository, and not your local file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted PR Welcome Pull requests are welcome
Projects
None yet
Development

No branches or pull requests

3 participants