Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ViewSettingsDialog]: Selected field to sort is not updated to confirm function #6895

Open
1 task done
lateefsofi opened this issue Feb 4, 2025 · 2 comments
Open
1 task done

Comments

@lateefsofi
Copy link

Describe the bug

When we try to update sort field in ViewSettingsDialog we see selected field is not sent to the confirm callback rather previously selected item is sent.
This is not happening always, when we try to play around the selection then it happens.
If you see from below screenshot, I selected different sort fields couple of times and clicked Ok button. Notice last selection is "Company" but confirm callback is still providing "name" field
Image

Isolated Example

No response

Reproduction steps

  1. https://stackblitz.com/edit/github-t4s8sfx4?file=src%2FApp.tsx
  2. Open developer tools to see which fields is selected
  3. Play around the selection of fields
  4. after few selections you will notice selected field is not being sent to confirm callback

Expected Behaviour

When there is a new selection, new field should be sent to confirm call back.

Screenshots or Videos

Image

UI5 Web Components for React Version

2.4.0

UI5 Web Components Version

2.4.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Relevant log output

Organization

SAP SuccessFactors

Declaration

  • I’m not disclosing any internal or sensitive information.
@Lukas742
Copy link
Contributor

Lukas742 commented Feb 4, 2025

Hi @lateefsofi

I've updated your example to the latest ui5wc/r versions (2.7.0) and fixed the React key error. Now I'm not able to reproduce the issue, could you please check again?

https://stackblitz.com/edit/github-t4s8sfx4-ba16c6jb?file=package.json,src%2FApp.tsx

Also, this issue sounds familiar to what was fixed (included in v2.7.0) with this PR.

@lateefsofi
Copy link
Author

Hi @Lukas742 ,
We are trying to upgrade ui5-component to 2.7.1 and we are getting objectPageRef.current?.scrollTo is not a function in unit tests. What is the reason of this error?
Code failure: @ui5/webcomponents-react/dist/components/ObjectPage/index.js:187:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants